On Fri, Oct 11, 2013 at 03:31:32PM -0700, Alex Wang wrote: > > Thanks. I agree that the existing comment is wrong. I don't really > > understand the description of 'flow' in the new version. It implies > > that execute_actions() does something to 'flow' and especially to the > > tunnel and in_port members, but 'flow' is const so that's not the > > case. > > > Yes, I couldn't find a very good way to describe flow so I check the > function that calls execute_actions(). then I found and excerpt this > description from rule_execute() in ofproto-provider.h
Ah. That is a little different because it is a comment on a function pointer. In that context, it describes what the implementer of the function may rely on, rather than what the function does. It was hard for me to see that context in the transplanted comment. > How about this: > > > > /* Executes, within 'ofproto', the actions in 'rule' or 'ofpacts' > > * on 'packet'. 'flow' must reflect the data in 'packet'. */ > > > > > Yes, I'm fine with this. Thanks, I'll use it like that. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
