Thanks Ben, for the review,
Thanks. I agree that the existing comment is wrong. I don't really > understand the description of 'flow' in the new version. It implies > that execute_actions() does something to 'flow' and especially to the > tunnel and in_port members, but 'flow' is const so that's not the > case. > Yes, I couldn't find a very good way to describe flow so I check the function that calls execute_actions(). then I found and excerpt this description from rule_execute() in ofproto-provider.h How about this: > > /* Executes, within 'ofproto', the actions in 'rule' or 'ofpacts' > * on 'packet'. 'flow' must reflect the data in 'packet'. */ > Yes, I'm fine with this. > and if the additional sentence had additional meaning that I didn't > follow, you can add a sentence for that too.
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
