On Fri, Oct 11, 2013 at 09:06:41AM -0700, Ethan Jackson wrote:
> > +/* The following prototypes duplicate those in rconn.h, but there we 
> > weren't
> > + * able to add the OVS_EXCLUDED annotations because the definition of 
> > struct
> > + * rconn was not visible.   */
> 
> Extra space here.

Thanks, I fixed it.

> Pretty straight forward, I'm happy with this.  Thanks for pulling it
> together so quickly.

I really wish Clang didn't just report violations of thread safety on
prototypes seen earlier in the same file.  It means you have to make
sure that every function with a thread-safety annotation has a prototype
with the same annotation near the top of the file.

> Acked-by: Ethan Jackson <et...@nicira.com>

Great, I'll do a little more testing then apply this to master and
branch-2.0.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to