I wouldn't bother narrowing it. I was just confused about whether it's required or not. Perhaps a brief comment explaining that logic would be helpful.
Ethan On Fri, Oct 11, 2013 at 9:09 AM, Ben Pfaff <b...@nicira.com> wrote: > On Fri, Oct 11, 2013 at 08:58:20AM -0700, Ethan Jackson wrote: >> I guess the only thing I'm wondering about is how you know when >> ofproto_mutex is required and when it isn't. In particular, why do we >> need to hold it for the entire connmgr_set_controllers()? That's not >> totally clear from the comment at the top of the file. > > I don't think we need to hold it for the entire > connmgr_set_controllers(). I could probably narrow it, if you like. It > was a little easier to keep it for the entire span of the function and I > didn't think it would be a big deal because it's held for long times > elsewhere during flow mods etc. > >> Acked-by: Ethan Jackson <et...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
