I think you're right, it's unnecessary, so I left it out.
On Tue, Oct 08, 2013 at 07:28:07AM -0700, Alex Wang wrote: > Looks good to me, > > not sure if it is necessary to call coverage_run() here as well. but since > the dispatcher and other threads will call the coverage_run(), I think it > is okay either add here or not. > > > On Mon, Sep 23, 2013 at 10:49 AM, Ben Pfaff <b...@nicira.com> wrote: > > > The miss handler threads do not call poll_block(), which calls > > coverage_clear() indirectly. This meant that coverage counters incremented > > by miss handler threads never got integrated into the global coverage > > counters and therefore did not show up in coverage logging or > > "ovs-appctl coverage/show" output. This commit fixes the problem. > > > > Signed-off-by: Ben Pfaff <b...@nicira.com> > > --- > > ofproto/ofproto-dpif-upcall.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c > > index d75c61b..b210dec 100644 > > --- a/ofproto/ofproto-dpif-upcall.c > > +++ b/ofproto/ofproto-dpif-upcall.c > > @@ -410,6 +410,8 @@ udpif_miss_handler(void *arg) > > ovs_mutex_unlock(&handler->mutex); > > > > handle_miss_upcalls(handler->udpif, &misses); > > + > > + coverage_clear(); > > } > > } > > > > -- > > 1.7.10.4 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > http://openvswitch.org/mailman/listinfo/dev > > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
