Looks good to me, just one point,
I think the following code should be protected by the lock.
@@ -503,6 +533,14 @@ netdev_dummy_send(struct netdev *netdev, const void
> *buffer, size_t size)
> dev->stats.tx_packets++;
> dev->stats.tx_bytes += size;
>
> + if (dev->tx_pcap) {
> + struct ofpbuf packet;
> +
> + ofpbuf_use_const(&packet, buffer, size);
> + pcap_write(dev->tx_pcap, &packet);
> + fflush(dev->tx_pcap);
> + }
> +
> for (i = 0; i < dev->n_streams; i++) {
> struct dummy_stream *s = &dev->streams[i]
>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
