On Mon, Sep 30, 2013 at 10:13:44AM +0900, Simon Horman wrote: > On Fri, Sep 27, 2013 at 12:30:10PM -0700, Ben Pfaff wrote: > > On Fri, Sep 27, 2013 at 09:18:32AM +0900, Simon Horman wrote: > > > From: Joe Stringer <j...@wand.net.nz> > > > > > > This patch adds a new compatibility enum for use with MPLS, so that the > > > differing behaviour between OpenFlow 1.2 and 1.3 can be implemented in > > > ofproto-dpif-xlate. > > > > It seems a little awkward to me to do this via a new OFPACT_, mostly > > because there isn't currently any distinction between OF1.1 and OF1.3 in > > terms of OFPACT_ definitions. Did you consider adding a new field to > > struct ofpact_push_mpls that would say whether the label should be added > > before or after a VLAN tag? > > I think that the main reason that Joe and I (probably much more I than Joe) > chose to use OFPACT_ the way that we did is that it seemed to be in keeping > with the way the code already works. Clearly you don't feel that is the > case which seems entirely reasonable to me. I'll see about re-working the > code as you have suggested.
Thanks. I think that it will make the code easier to understand. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
