I recall having a bit of discussion regarding this approach and whether to change it, but I don't recall the issues around this.
Your suggestion sounds sane. What are your thoughts, Simon? On Sat, Sep 28, 2013 at 7:30 AM, Ben Pfaff <b...@nicira.com> wrote: > On Fri, Sep 27, 2013 at 09:18:32AM +0900, Simon Horman wrote: > > From: Joe Stringer <j...@wand.net.nz> > > > > This patch adds a new compatibility enum for use with MPLS, so that the > > differing behaviour between OpenFlow 1.2 and 1.3 can be implemented in > > ofproto-dpif-xlate. > > It seems a little awkward to me to do this via a new OFPACT_, mostly > because there isn't currently any distinction between OF1.1 and OF1.3 in > terms of OFPACT_ definitions. Did you consider adding a new field to > struct ofpact_push_mpls that would say whether the label should be added > before or after a VLAN tag? >
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
