On Aug 26, 2013, at 10:45 AM, Ben Pfaff <b...@nicira.com> wrote:

> On Tue, Aug 20, 2013 at 06:41:44PM -0700, Jarno Rajahalme wrote:
>> Remove push_vlan from an OF1.0 test, as it requires OF1.1+ support, but was
>> silently discarded.
>> 
>> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>
> 
> I agree that we should not expect OF1.1+ features to work in OF1.0,
> but I think that this test result demonstrates a bug somewhere in OVS:
> it is incorrect to silently discard an action.  I would prefer to fix
> that, rather than to just stop trying it.


The later patch does that, as it does "usable protocol" analysis while parsing 
the actions (and matches). After applying the patch 2/2 the test modified here 
will fail, hence the modification.

The issue is a bit more subtle, as silently ignoring a single vlan push kind of 
works, as a subsequent setting of a vlan ID will implicitly add the vlan header 
if it did not exist previously.

  Jarno

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to