On Tue, Aug 20, 2013 at 06:41:45PM -0700, Jarno Rajahalme wrote: > Keep track of usable protocols while parsing actions and matches, > rather than checking for them afterwards. This fixes silently discarded > meter and goto table instructions when not explicitly specifying the > protocol to use. > > Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>
I was uncertain about this upon first posting a while back, but upon reflection I like it. I think that it will make it harder to get the usable protocols wrong when we add new fields, because it forces the developer to make a decision when adding the field to meta-flow.c. When we've got the first patch sorted out (I assume that without patch 1, this patch will cause test failures) I'm happy to apply this one. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
