On Wed, Aug 07, 2013 at 03:20:57PM -0700, Andy Zhou wrote:
> Acked-by: Andy Zhou <[email protected]>
Thanks.
> > - if (netdev_get_class(netdev_) == &netdev_tap_class) {
> > - destroy_tap(netdev);
> > + if (netdev_get_class(netdev_) == &netdev_tap_class
> > + && netdev->tap_fd >= 0)
> >
> Should we make netdev->tap_fd >= 0 an assert?
It could be an assert, I guess. This patch is trying to be just a code
cleanup without changing behavior.
> Could zero be a valid tap_fd value?
Theoretically yes. Most people wouldn't bother to worry about that, but
coreutils does so I've always found it better to write >= 0 rather than
> 0 to test for an invalid fd value.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
