On Tue, Jul 16, 2013 at 10:41:25AM -0700, Gurucharan Shetty wrote:
> On Fri, Jul 12, 2013 at 2:54 PM, Ben Pfaff <b...@nicira.com> wrote:
>
> > The simplification comes from dropping support for canceling a
> > poll_waiter, which was a feature that was never used. The speedup
> > comes from avoiding a malloc() for every call to poll_fd_wait().
> > (I doubt that this significantly improves performance.)
> >
> > This prepares for making the polling structures per-thread in
> > the next commit.
> >
> > Signed-off-by: Ben Pfaff <b...@nicira.com>
> > -poll_cancel(struct poll_waiter *pw)
> > -{
> > - if (pw) {
> > - list_remove(&pw->node);
> > - free(pw);
> > - }
> > -}
> >
> > /* Creates and returns a new poll_waiter for 'fd' and 'events'. */
> >
> The comment needs an update as we no longer return anything.
Thanks, I've now updated it.
> -static struct poll_waiter *
> > +static void
> > new_waiter(int fd, short int events, const char *where)
...
> Looks good to me.
Thank you for the review.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
