On 12 July 2013 17:54, Ben Pfaff <[email protected]> wrote:

> Signed-off-by: Ben Pfaff <[email protected]>
>

Acked-by: Ed Maste <[email protected]>

with one comment,

diff --git a/lib/latch.c b/lib/latch.c
> +void
> +(latch_wait)(const struct latch *latch, const char *where)
>
...

> diff --git a/lib/latch.h b/lib/latch.h
> +#define latch_wait(latch) latch_wait(latch, SOURCE_LOCATOR)
>

This seems like it will be confusing for those who aren't C preprocessor
gurus, and might trip up source indexing / analysis tools.  I see that
there are a few other examples in OVS already though.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to