On Jun 28, 2013, at 19:33 , ext Ben Pfaff wrote: > On Fri, Jun 28, 2013 at 04:28:40PM +0000, Rajahalme, Jarno (NSN - FI/Espoo) > wrote: >> >> On Jun 28, 2013, at 19:09 , ext Ben Pfaff wrote: >> >>> On Fri, Jun 28, 2013 at 07:17:09AM +0000, Rajahalme, Jarno (NSN - FI/Espoo) >>> wrote: >>>> >>>> On Jun 28, 2013, at 1:19 , ext Ben Pfaff wrote: >>>>> ofproto: Use another method to find meter_id. >>>> >>>> OK, with the rationale that actions lists are short on average, so >>>> it does not matter scanning them twice. >>> >>> I agree, but my actual rationale here was that, if it is present, the >>> meter action will always be the first one, because of the ordering >>> constraints. >> >> I did not came to think about that, but for flows without a meter >> instruction this does not matter... > > Not sure what you mean by that. To expand: if there's a meter > instruction, it will be the first ofpact, so if we hit something that > is not a meter instruction we can stop looking. The actual code is a > little more general in case we add another instruction that gets > ordered before the meter instruction, but it should have the same > effect.
Sorry for sloppy reading on my part. I just meant that the ordering does not help (w.r.t. scanning this list twice) if there is no meter action. Jarno _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
