On Jun 28, 2013, at 1:19 , ext Ben Pfaff wrote: > I spent some time looking at and playing with patch 4/5 "v2: ofproto: > Implement OpenFlow 1.3 meter table." and decided that there was a fair bit > that I wanted to tweak. This series represent what I came up with: > > IMPORTANT: In this series, I intend to squash all the patches after > "Implement OpenFlow 1.3 meter table" into that patch before pushing. > > Jarno, what do you think? > > Patches: > ofp-actions: Give ovs_instruction funcs names that start with that > prefix.
Good. > ofpact: New function ovs_instruction_type_from_ofpact_type(). Great. > ofproto: Implement OpenFlow 1.3 meter table. OK. > ofproto: Change 'const uint32_t *meter_id' to just 'uint32_t > meter_id'. I guess I didn't see this while changing away from a struct to just the meter id. Thanks! > ofproto: Use another method to find meter_id. OK, with the rationale that actions lists are short on average, so it does not matter scanning them twice. > ofproto: Allocate meter bands separately from the meters themselves. Simpler, yes. Also, I had not noticed that x*alloc functions bail out when no more memory is available, thanks for letting me know :-) > ofproto: Meter-related comment updates. Clearer, thanks. > ofproto: Get rid of 'last_meter'. Given that controllers can anyway freely use the whole range of available meters this is a good simplification. > ofproto: Break handle_meter_mod() into sub-functions. > Bite-size functions are better, thanks! > > lib/ofp-actions.c | 123 +++++++++--- > lib/ofp-actions.h | 17 +-- > lib/ofp-parse.c | 2 +- > lib/rconn.c | 14 +- > ofproto/ofproto-dpif.c | 4 + > ofproto/ofproto-provider.h | 57 ++++++- > ofproto/ofproto.c | 452 +++++++++++++++++++++++++++++++++++++++++--- > ofproto/ofproto.h | 3 + > 8 files changed, 590 insertions(+), 82 deletions(-) > > -- > 1.7.2.5 > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
