On Jun 20, 2013, at 5:04 PM, Ben Pfaff <b...@nicira.com> wrote: > On Thu, Jun 20, 2013 at 04:51:54PM -0700, Justin Pettit wrote: >> If a flow cannot be installed in the datapath, we should notice >> this and not treat it as installed. This becomes an issue with >> megaflows, since a batch of unique flows may come in that generate >> a single new datapath megaflow that covers them. Since userspace >> doesn't know whether the datapath supports megaflows, each unique >> flow will get a separate flow entry (which overlap when masks are >> applied) and all except the first will get rejected by a megaflow- >> supporting datapath as duplicates. >> >> Signed-off-by: Justin Pettit <jpet...@nicira.com> > > The new comment in struct flow_miss_op talks about destroying > subfacets, but actually we just mark them as not installed. > > Same for a new comment in handle_miss_upcalls().
Whoops. Fixed. Thanks, --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
