On Thu, May 16, 2013 at 10:36:15PM -0700, Justin Pettit wrote:
>
> On May 16, 2013, at 10:30 PM, Ben Pfaff <[email protected]> wrote:
>
> > 'netdev' is not initialized at this point in the function, so the cleanup
> > at the error label references a wild pointer (and is not useful anyhow).
> >
> > Introduced in commit 94a538422d4b (netdev: Prevent using reserved names).
> >
> > CC: Alex Wang <[email protected]>
> > Signed-off-by: Ben Pfaff <[email protected]>
> > ---
> > v1->v2: Fix Alex's email address.
>
> I strongly advise you not look at the Wikipedia article for penectomy.
I will not look at the Wikipedia article for penectomy, thanks.
> > --- a/vswitchd/bridge.c
> > +++ b/vswitchd/bridge.c
> > @@ -1421,8 +1421,7 @@ iface_do_create(const struct bridge *br,
> > if (netdev_is_reserved_name(iface_cfg->name)) {
> > VLOG_WARN("could not create interface %s, name is reserved",
> > iface_cfg->name);
> > - error = EINVAL;
> > - goto error;
> > + return EINVAL;
> > }
>
> For iface_do_create()'s interface, don't you need to set "*netdevp" to NULL?
This is why we do code reviews. Thanks. v3 coming up.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
