'netdev' is not initialized at this point in the function, so the cleanup
at the error label references a wild pointer (and is not useful anyhow).

Introduced in commit 94a538422d4b (netdev: Prevent using reserved names).

CC: Alex Wang <al...@nicira.com>
Signed-off-by: Ben Pfaff <b...@nicira.com>
---
v1->v2: Fix Alex's email address.

 vswitchd/bridge.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 28e306e..71aae15 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -1421,8 +1421,7 @@ iface_do_create(const struct bridge *br,
     if (netdev_is_reserved_name(iface_cfg->name)) {
         VLOG_WARN("could not create interface %s, name is reserved",
                   iface_cfg->name);
-        error = EINVAL;
-        goto error;
+        return EINVAL;
     }
 
     error = netdev_open(iface_cfg->name,
-- 
1.7.10.4

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to