On Wed, May 08, 2013 at 10:50:15AM +0900, Simon Horman wrote: > Do not perform validation in learn_parse(); > I believe this is consistent with the handling of all other action > parsing called from parse_named_action(). > > Verification of all actions, including learn actions, occurs separately > in ofpact_check__(). It also occurs via in a call to ofpacts_check() > in parse_ofp_str(), > > This patch is larger than might otherwise be expected as the flow argument > of learn_parse() is now unused and thus removed. This propagates up the > call-chain some way. > > This implementation was suggested by Jesse Gross in response to an > enhancement I made to the validation performed during parsing learn actions > to allow it to correctly account for changes to the dl_type due to MPLS > push and pop actions. > > Tests have also been updated to check for the less specific messages > generated by the call to ofpacts_check() in parse_ofp_str() which at the > suggestion of Ben Pfaff was added by a prior patch for this purpose. > > Cc: Jesse Gross <je...@nicira.com> > Cc: Ben Pfaff <b...@nicira.com> > Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
Both applied to master, thanks. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
