The validation in learn_parse() has two problems. 1. It does not correctly take into account dl_type changes that may occur due to push and pop MPLS actions. This may lead to both false positives and false negatives when checking the pre-requisites for fields.
2. It is inconsistent with the parsing of other actions which do not perform validation. This short series addresses this problem by: 1. Adding action validation to parse_ofp_str. 2. Removing validation from learn_parse. Simon Horman (2): Check actions prerequisites in parse_ofp_str() Do not perform validation in earn_parse() lib/learn.c | 25 +------------------------ lib/learn.h | 2 +- lib/ofp-parse.c | 28 ++++++++++++++++++---------- tests/learn.at | 12 +++++++----- tests/ovs-ofctl.at | 10 +++++----- 5 files changed, 32 insertions(+), 45 deletions(-) -- 1.7.10.4 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
