On Thu, Apr 18, 2013 at 11:02:26AM -0700, Justin Pettit wrote: > On Apr 18, 2013, at 9:56 AM, Ben Pfaff <[email protected]> wrote: > > > On Thu, Apr 18, 2013 at 09:46:30AM -0700, Justin Pettit wrote: > >> On Apr 18, 2013, at 9:28 AM, Ben Pfaff <[email protected]> wrote: > >> > >>> But I'm not sure about the test. It tries to connect to the default > >>> OpenFlow port on localhost. I guess that there will ordinarily be no > >>> OpenFlow controller listening there. Does the test still pass if there > >>> is, though? And assuming that it does, do we think that it is OK to do > >>> that in the unit tests? It could at least surprise the administrator of > >>> that controller, if there is one. > >> > >> Do you have a better suggestion? All the hidden flows I see are based > >> on a controller being set. > > > > One way would be to start an ovs-controller process and then set the > > switch to connect to it. You'd probably want to tell the controller to > > listen on ptcp:0:127.0.0.1 and then check the log to find out what port > > it's really listening on. There are examples of this in the series that > > I posted on April 3 starting here: > > http://openvswitch.org/pipermail/dev/2013-April/026432.html > > Hey?wait a second. I think this was a not so subtle attempt at > getting some of your code reviewed. This series is only a couple of > weeks old, so I don't know if it's breathed enough yet. But I'll take > a look at it today.
I've been keeping this particular series in a decanter to aerate it, so it might be ready. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
