On Tue, Apr 02, 2013 at 08:38:17AM -0700, Justin Pettit wrote: > Hidden flows, such as in-band control, are not visible when using > OpenFlow to view stats. However, the OpenFlow Table Stats message would > report them back, which is confusing. This commit changes the code to > count only visible flows. > > Reported-by: Prashant Chougule <[email protected]> > Signed-off-by: Justin Pettit <[email protected]>
The code looks OK to me. But I'm not sure about the test. It tries to connect to the default OpenFlow port on localhost. I guess that there will ordinarily be no OpenFlow controller listening there. Does the test still pass if there is, though? And assuming that it does, do we think that it is OK to do that in the unit tests? It could at least surprise the administrator of that controller, if there is one. Also, I spent some time staring at the code that generates the second version of expout in the test. I couldn't figure out what actually changes. What is the difference between the pre-"set-controller" and post-"set-controller" output of "dump-tables"? Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
