On Mar 5, 2013, at 9:58 AM, Ben Pfaff <b...@nicira.com> wrote: > On Mon, Mar 04, 2013 at 10:56:21PM -0800, Justin Pettit wrote: >> In the kernel tunnel implementation, if a packet was marked as ECN CE on >> the outer packet then we would carry this over to the inner packet on >> decapsulation. With the switch to flow based tunneling, this stopped >> happening. This commit reintroduces that behavior by using the set IP >> header action. >> >> Bug #15072 >> >> Signed-off-by: Justin Pettit <jpet...@nicira.com> > > This looks good, thanks. I have one trivial comment. > > The indentation of the && clause here looks funny to me,
Yeah, I went back and forth on that. I followed the code block in the function immediately before it, but I assume you'd prefer it left four spaces. I've changed it to that, but let me know if you actually have a different preference. > also there's an extra set of () around the == clause: Changed. Thanks for the reviews! I'll just wait for your feedback on the incremental I sent for part 2 before pushing the series. --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
