On Mon, Mar 04, 2013 at 10:56:19PM -0800, Justin Pettit wrote: > When a packet arrives on an IP tunnel, store the TOS value for later > use. This value will be used in a couple of future commits. > > Signed-off-by: Justin Pettit <jpet...@nicira.com>
Looks good, only one trivial comment: > + * Optionally, if 'initial_vals' is nonnull, sets '*initial_vals->vlan_tci' > + * to the VLAN TCI with which the packet was really received, that is, the > + * actual VLAN TCI extracted by odp_flow_key_to_flow(). (This differs from > + * the value returned in flow->vlan_tci only for packets received on > + * VLAN splinters.) Also, if received on an IP tunnel, sets The "*" in '*initial_vals->tunnel_ip_tos' is wrong here too I think: > + * '*initial_vals->tunnel_ip_tos' to the tunnel's IP TOS. > * > * Similarly, this function also includes some logic to help with tunnels. > It > * may modify 'flow' as necessary to make the tunneling implementation _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
