On Wed, Jan 09, 2013 at 03:43:44PM -0800, Ethan Jackson wrote: > Future patches will need to know the details of a netdev's tunnel > configuration from outside the netdev library. > > Signed-off-by: Ethan Jackson <et...@nicira.com>
The one thing that seems just a little odd about this is that it embraces the new struct netdev_tunnel_config less than I would have guessed. parse_tunnel_config() is where I noticed it the most: I would have expected that it would transform the key-value pairs into a struct netdev_tunnel_config, then the struct netdev_tunnel_config into netlink attributes in a second step. However, the code seems OK to me, it just wasn't exactly what I was expecting. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev