On Wed, Jan 9, 2013 at 3:43 PM, Ethan Jackson <et...@nicira.com> wrote: > diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c > index 736081c..3e0688b 100644 > --- a/lib/netdev-vport.c > +++ b/lib/netdev-vport.c [...] > + tnl_cfg.in_key = parse_key(args, "in_key", > + &tnl_cfg.in_key_present, > + &tnl_cfg.in_key_flow); > + if (tnl_cfg.in_key_present && !tnl_cfg.in_key_flow) { > + nl_msg_put_be64(options, OVS_TUNNEL_ATTR_IN_KEY, tnl_cfg.in_key); > + } > + > + tnl_cfg.out_key = parse_key(args, "out_key", > + &tnl_cfg.out_key_present, > + &tnl_cfg.out_key_flow); > + if (!tnl_cfg.out_key_flow) { > + nl_msg_put_be64(options, OVS_TUNNEL_ATTR_OUT_KEY, tnl_cfg.out_key); > + }
I think we need to drop the check for tnl_cfg.in_key_present similar to what you did for the out_key. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev