On Wed, Dec 26, 2012 at 8:16 PM, Ethan Jackson <et...@nicira.com> wrote:
> diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
> index acf7d18..a95e09e 100644
> --- a/lib/netdev-vport.c
> +++ b/lib/netdev-vport.c
>  netdev_vport_set_etheraddr(struct netdev *netdev,
>                             const uint8_t mac[ETH_ADDR_LEN])
[...]
> +    memcpy(netdev_get_vport_dev(netdev)->etheraddr, mac, sizeof mac);

I didn't notice this before but using sizeof mac here (and in the get
function) is actually going to result in copying a pointer's worth of
data so I think you want to explicitly use ETH_ADDR_LEN.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to