On Fri, Nov 16, 2012 at 12:19 PM, Ben Pfaff <b...@nicira.com> wrote:

> On Fri, Nov 16, 2012 at 12:00:05PM -0800, Justin Pettit wrote:
> > Commit acf608 (ofproto-dpif: Use a single underlying datapath across
> > multiple bridges.) causes datapath flows from deleted ports to not be
> > removed.  The issue is that the code that bulk deletes old flows doesn't
> > know the datapath port number that makes up the datapath flow
> > definition.  This commit keeps track of the datapath port in the facet
> > for use when the datapath flow eventually needs to be removed.
> >
> > Signed-off-by: Justin Pettit <jpet...@nicira.com>
>
> Would you mind adding some rationale to the comment on the 'odp_in_port'
> member in struct subfacet?  Otherwise I'll come along in a few months
> and have to figure out why we need this.
>

Done.

Otherwise this looks good, thank you.
>

Thanks for the quick turn-around on the reviews.  I'll push the series in a
moment.

--Justin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to