On Fri, Nov 16, 2012 at 12:03:02AM -0800, Justin Pettit wrote: > The kernel datapath automatically "up"s internal devices, but this > wasn't happening for the userspace datapath. This change has the bridge > module always "up" them. > > Signed-off-by: Justin Pettit <jpet...@nicira.com>
Seems reasonable, thanks. The indentation here, on the second line, looks odd to me: if ((port_cfg->vlan_mode && !strcmp(port_cfg->vlan_mode, "splinter")) || iface_is_internal(iface_cfg, br->cfg)) { I would write it as: if ((port_cfg->vlan_mode && !strcmp(port_cfg->vlan_mode, "splinter")) || iface_is_internal(iface_cfg, br->cfg)) { _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev