On Tue, Sep 04, 2012 at 03:52:01PM +0900, Simon Horman wrote: > * In the case of OpenFlow 1.2+ OFPERR_OFPBRC_BAD_PORT is defined > in the specification and seems to be the most appropriate error > to use when an invalid port is encountered in a Packet Out request. > > * In the case of OpenFlow 1.0 and 1.1 no appropriate error message > seems to exist. Perhaps because an invalid port is not possible? > I'm unsure. > > In any case, make use of a non-standard error code (1,514). > This was formerly known as OFPERR_NXBRC_BAD_IN_PORT but > has been rolled into OFPERR_NXBRC_BAD_IN_PORT to allow the > latter to be used without concern for the prevailing Open Flow version. > > Signed-off-by: Simon Horman <ho...@verge.net.au>
I get patch rejects, probably trivial to resolve, but this: > - /* OF1.2+(1,11). Invalid port. */ > + /* OF1.0(1,514), OF1.1(1,514), OF1.2+(1,11). Invalid port. > + * A non-standard error (1,514), formerly > + * OFPERR_NXBRC_BAD_IN_PORT is used for OpenFlow 1.0 and 1.1 as there > + * seems to be no appropriste error code defined the specifications */ > OFPERR_OFPBRC_BAD_PORT, needs some kind of update to build-aux/extract-ofp-errors, because as-is the commentary will show up in the error description. We could, for example, say that a blank line causes the rest of the description to be omitted, or to ignore anything in square brackets, or... _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
