Hi, following recent discussion on the dev mailing list I have prepared this series of patches which aims to make use of standardised error messages where possible in cases where the error does not arise during the course of the use of an NX extension.
I have intentionally left OFPERR_NXBRC_BAD_REASON as is as there seems to be no appropriate standardised code up to Open Flow 1.2. The series also leaves in place the use of non-standard codes for some Open Flow versions in cases where there appear to be no standardised codes. The lack of standardised codes, even generic ones, was a surprising and not particularly positive aspect of this exercise. Balancing that, a slight overall reduction in the lines of code is a positive aspect of this exercise. Availability ------------ This series is based on the current mainline master branch. The patches are available in the devel/ofp-errors branch of git://github.com/horms/openvswitch.git The current head commit-id is 3e910773c5097097c88b37ccd9e320d839459200 Patches ------- [PATCH 1/5] ofp-errors: Remove OFPERR_NXBIC_DUP_TYPE [PATCH 2/5] ofp-errors: Remove OFPERR_NXFMFC_GROUPS_NOT_SUPPORTED [PATCH 3/5] ofp-errors: Use OFPERR_OFPBRC_BAD_PORT [PATCH 4/5] ofp-errors: Use OFPERR_OFPBRC_BAD_TABLE_ID [PATCH 5/5] ofp-errors: Use standardised code for Overall Diffstat ---------------- lib/ofp-actions.c | 2 +- lib/ofp-errors.h | 24 +++++++++--------------- lib/ofp-util.c | 11 +++-------- ofproto/ofproto-dpif.c | 2 +- ofproto/ofproto-provider.h | 2 +- ofproto/ofproto.c | 4 ++-- 6 files changed, 17 insertions(+), 28 deletions(-) _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
