On Fri, Jun 29, 2012 at 01:41:31PM +0900, Isaku Yamahata wrote: > On Fri, Jun 29, 2012 at 09:12:04AM +0900, Simon Horman wrote: > > On Thu, Jun 28, 2012 at 09:13:21PM +0900, Simon Horman wrote: > > > 2012/06/28 20:34 "Isaku Yamahata" <yamah...@valinux.co.jp>: > > > > > > > > Hi Simon. When I compiled it, I got the followings > > > > Although I can fix it myself, it would be better to leave it to you. > > > > > > > > > ../utilities/ovs-ofctl.c: In function 'fetch_port_by_features': > > > > > ../utilities/ovs-ofctl.c:549:63: warning: 'vconn' is used > > > > > uninitialized > > > in this function [-Wuninitialized] > > > > > ../utilities/ovs-ofctl.c: In function 'do_show': > > > > > ../utilities/ovs-ofctl.c:500:63: warning: 'vconn' is used > > > > > uninitialized > > > in this function [-Wuninitialized] > > > > > > > > My gcc version is > > > > > $ gcc --version > > > > > gcc (Debian 4.7.0-8) 4.7.0 > > > > > Copyright (C) 2012 Free Software Foundation, Inc. > > > > > This is free software; see the source for copying conditions. There > > > > > is > > > NO > > > > > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR > > > PURPOSE. > > > > > > Thanks, I will fix that tomorrow. > > > > Hi Yamahata-san, > > > > are you sure that you have the latest version of my series? > > I see vconn as a parameter to fetch_port_by_features(). > > > > I am using the same version of gcc as you but I am not > > do not seeing the warning you are seeing. > > > > The latest patches are revision dd1cf6fe49d0839e692d8bafbd9cb70eeb41771a > > of the devel/of12 branch of git://github.com/horms/openvswitch.git. > > Oops. I rebased to the change set. gcc still complains as follows. > Anyway the tree is under heavy development, so I'm not so worried about it. > > ../lib/ofp-print.c: In function 'ofp_to_string': > ../lib/ofp-print.c:1135:106: warning: 'ps.port_no' may be used uninitialized > in this function [-Wmaybe-uninitialized]
I believe that this is resolved in dd1cf6fe49d0839e692d8bafbd9cb70eeb41771a. In any case, I see no access to ps.port_no on line 1135, could you send me a copy or revision of your tree to check if the problem seems to still be present? > ../lib/ofp-print.c:1101:29: note: 'ps.port_no' was declared here > ../utilities/ovs-ofctl.c: In function 'do_queue_stats': > ../utilities/ovs-ofctl.c:822:9: warning: large integer implicitly truncated > to unsigned type [-Woverflow] Thanks, I noticed that one too. My fix is to change queue_id from uint16_t to uint32_t. > ../utilities/ovs-ofctl.c: In function 'do_show': > ../utilities/ovs-ofctl.c:500:63: warning: 'vconn' is used uninitialized in > this function [-Wuninitialized] Thanks, that I did not notice. I believe that a good fix is to move the call to open_vconn() to above the call to make_openflow(). This should ensure that vconn is initialised the first time it is used. And thus vconn_get_version() should return a valid version for use by make_openflow(). _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
