On Thu, May 17, 2012 at 09:06:17AM -0700, Ben Pfaff wrote: > On Thu, May 17, 2012 at 09:00:18AM -0700, Ben Pfaff wrote: > > On Thu, May 17, 2012 at 05:59:00PM +0900, Simon Horman wrote: > > > this is a first pass at providing a tun_key which can be used > > > as the basis for flow-based tunnelling. The tun_key includes and > > > replaces the tun_id in both struct ovs_skb_cb and struct sw_tun_key. > > > > > > In ovs_skb_cb tun_key is a pointer as it is envisaged that it will grow > > > when support for IPv6 to an extent that inlining the structure will result > > > in ovs_skb_cb being larger than the 48 bytes available in skb->cb. > > > > > > As OVS does not support IPv6 as the outer transport protocol for tunnels > > > the IPv6 portions of this change, which appeared in the previous revision, > > > have been dropped in order to limit the scope and size of this patch. > > > > > > This patch does not make any effort to retain the existing tun_id > > > behaviour > > > nor does it fully implement flow-based tunnels. As such it it is > > > incomplete > > > and can't be used in its current form (other than to break OVS > > > tunnelling). > > > > This patch doesn't actually remove OVS_KEY_ATTR_TUN_ID (although it > > renumbers it) or all the references to it. I'm surprised, what's the > > reasoning there? > > I misread your commit message, it's only the internal struct members > you're replacing, not OVS_KEY_ATTR_TUN_ID. Never mind.
It probably could remove OVS_KEY_ATTR_TUN_ID if I re-aranged the series a little. I'll see about making things clearer somehow. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
