> Questions > --------- > > bridge_reconfigure_ofp() has the following comment: > /* Do any work needed to complete configuration. Don't consider ourselves > * done unless no work was needed in this iteration. This guarantees that > * ofproto_run() has a chance to respond to newly added ports. */ > I don't understand the implications. What is the effect if > ofproto_run() does not get a chance to look at newly added ports? > Does the existing code do this?
I thought it helped with an issue I was running into, but it turned out not to and I forgot to remove it. > Cleanups (and possible performance improvements) > ------------------------------------------------ For some reason I thought that iterating through ofproto ports only hit the ofproto code and didn't go all the way to the datapath which is why I did it so liberally. It wasn't a big deal to optimize it. I will shortly be sending out both an incremental, and the full patch again. Thanks for the review. Ethan _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
