This looks good to me, thanks. Few nits that don't effect correctness:
Unnecessary lines in try block, move this
path_entries.append((path, s))
to outside the block
>From a style nit perspective, there are a few line continuations and
indentations that seem non-standard. google style doesn't like
line continuations, can replace with nothing (if implied by the \
parenthesis/bracket already), or by adding parenthesis instead.
for example remove the \ from the first line, re-indent the second
fns = [fn for fn in [os.path.join(root, f) for f in files] \
if os.path.isfile(fn) and matches(fn, pattern, negate)]
-Reid
On Fri, Mar 23, 2012 at 3:08 PM, Ben Pfaff <[email protected]> wrote:
> On Fri, Mar 23, 2012 at 03:06:54PM -0700, Raju Subramanian wrote:
> > When size limit is reached in the middle of processing a dir,
> > the report ends up containing oldest files. This change adds
> > an optional param in the plugin to prioritize newer files.
> >
> > Feature #9937
> > Requested-by: Ronald Lee <[email protected]>
> > Signed-off-by: Raju Subramanian <[email protected]>
>
> Thanks, I'm OK with this but I'd like another round of feedback from
> Reid.
> _______________________________________________
> dev mailing list
> [email protected]
> http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
