> It looks OK to me (although "except Exception" seems a bit overbroad).
It should catch an OSError: http://docs.python.org/library/exceptions.html#exceptions.OSError The problem with "except Exception" is you swallow exceptions that are indicative of bugs. If something throws an AssertionError for example, except Exception would catch it, which is not what we want. Ethan > > Reid, do you have any more feedback? > > Thanks, > > Ben > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
