> > > I think that fcmp(x,y) can just "return cmp(x[1].st_mtime, y[1].st_mtime)". >
Removed. Implemented what Reid suggested. > I think that the try...except around the arithmetic in file_output is > no longer necessary. removed. > However, I don't think that this is safe: > > + path_entries = [(path, os.stat(path)) for path in path_list if > os.path.exists(path)] > At least, there is a race between the "exists" test and the "stat" > call. > > Split into separate calls. > Thanks, > > Ben. >
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
