On Fri, Mar 23, 2012 at 07:10:20AM -0700, Raju Subramanian wrote: > When size limit is reached in the middle of processing a dir, > the report ends up containing oldest files. This change adds > an optional param in the plugin to prioritize newer files. > > Feature #9937 > Requested-by: Ronald Lee <r...@nicira.com> > Signed-off-by: Raju Subramanian <rsubraman...@nicira.com>
I think that fcmp(x,y) can just "return cmp(x[1].st_mtime, y[1].st_mtime)". I think that the try...except around the arithmetic in file_output is no longer necessary. However, I don't think that this is safe: > + path_entries = [(path, os.stat(path)) for path in path_list if > os.path.exists(path)] At least, there is a race between the "exists" test and the "stat" call. The tree_output function is documented as processing files less nested in the directory tree before those deeper in the directory tree. It doesn't do that anymore, so you should update the documentation. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
