On Tue, Mar 13, 2012 at 02:58:30PM -0700, Chris Wright wrote: > * Ben Pfaff (b...@nicira.com) wrote: > > On Tue, Mar 13, 2012 at 12:18:07PM -0700, Chris Wright wrote: > > > This adds ability to do: > > > > > > ./configure --disable-brcompat > > > > > > to disable building userspace and kernel module associated with > > > providing linux bridge compatibility. Sources should still be > > > distributed w/ make dist. > > > > > > While there, update comment referring to long removed veth driver > > > which is now relevant for brcompat module. > > > > > > Signed-off-by: Chris Wright <chr...@sous-sol.org> > > > > "git am" says: > > > > Applying: configure: add configure option to disable building brcompat > > /home/blp/ovs/.git/rebase-apply/patch:81: trailing whitespace. > > [AC_HELP_STRING([--disable-brcompat], > > /home/blp/ovs/.git/rebase-apply/patch:72: new blank line at EOF. > > + > > warning: 2 lines add whitespace errors. > > Thanks, cut'n paste error on the trailing whitespace. I can submit > another patch to fix that file if you're interested. > > > In the OVS_CHECK_BRCOMPAT macro definition, the "yes" case and the > > "not specified" case are different (the "yes" sets BUILD_BRCOMPAT, the > > "missing" case does not), but I do not see why. > > Simply a bug, good catch.
OK, will you submit a v3 with at least that fixed then? (Also I guess Jesse should at least "ack" this patch.) Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
