On Mon, Jan 16, 2012 at 05:57:38PM -0800, Ethan Jackson wrote: > While debugging some issues today it became clear that it would be > useful to log when the CFM fault status changes and when packets > are lost. The CFM module logs pretty aggressively when in debug > mode, but this can be chatty and most systems don't operate under > this logging level for extended periods of time. This patch logs > when CCMs are received which indicate reordering or packet loss and > when the CFM fault status changed. > > Requested-by: Jacob Cherkas <jcher...@nicira.com> > Signed-off-by: Ethan Jackson <et...@nicira.com>
This is a good idea. Thank you! Please add Jacob to AUTHORS. This adds an odd blank line near the end of cfm_run(). The current message reports missing sequence numbers, but I think that there are at least two other possible issues: duplicate sequence numbers and out-of-order sequence numbers. It might be a good idea either to detect and report these with separate messages (based on whether the new sequence number is greater than, less than, or equal to the previous number), or to make the single message make a less specific claim about the problem. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
