On Nov 22, 2011, at 3:12 PM, Ben Pfaff wrote: > /* Upcall messages. */ > struct nl_sock *upcall_socks[N_UPCALL_SOCKS]; > - int last_read_upcall; > + uint32_t nonempty_socks;
I think it would be helpful to point out that this is a mask--either through a comment or appending "_mask" to the name. Otherwise, looks good. --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev