On Thu, Nov 10, 2011 at 05:46:26PM -0800, Justin Pettit wrote:
> > and maybe we should even change the
> > member name in struct ofp_match to nw_dscp (or whatever you like).
> 
> 
> As you know, the interplay of TOS and DSCP in OpenFlow are a passion
> of mine.  I've kept that field name "nw_tos", since it's using the bit
> positions of TOS but only the DSCP portion is matchable.  Assuming
> OpenFlow 1.2 moves the DSCP match over by two bits, then true DSCP
> matches (ie, a range of 0-63) will have a name with "dscp" in them.
> (I just realized that I broke this convention in
> cls_rule_set_nw_dscp(), so I'll send out a follow-up patch for that.
> Oh joy!)

OK.

I'm always amazed how others see inconsistency where I just see
hobgoblins, though.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to