On Wed, Nov 09, 2011 at 11:59:08PM -0800, Justin Pettit wrote:
> Most of the members in structures referring to network elements indicate
> the layer (e.g., "tl_", "nw_", "tp_").  The "frag" and "tos" members
> didn't, so this commit add them.

The nw_tos members of struct flow and struct ofp_match have different
meanings, but the comment in struct flow doesn't really hint at that.
It would be good to be more explicit, e.g. change the comment to "IP
ToS (including DSCP and ECN)" and maybe we should even change the
member name in struct ofp_match to nw_dscp (or whatever you like).
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to