On Sun, Nov 06, 2011 at 12:34:24PM -0800, Jesse Gross wrote: > Many of the function in vport.c are simply pass throughs to their > underlying vport implementation and, of these, many are used only > for bridge compatibility code. This allows users of these functions > to directly call through the ops structure, reducing boilerplate code > and keeping more of the compatibility code together. > > Signed-off-by: Jesse Gross <je...@nicira.com>
I think that this introduces the new assumption that if 'get_ifindex' is implemented then 'get_mtu' must also be implemented. That should be either reverted or documented in a comment on 'get_mtu', I think. Otherwise it looks good and fits much better with my understanding of kernel style. Acked-by: Ben Pfaff <b...@nicira.com> _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
