On Mon, Jul 18, 2011 at 03:05:19PM -0700, Ethan Jackson wrote: > > The "bundle" term is already used, with a different meaning, in the > > ofproto-private.h interface. ?We should rename one of them or the > > other; I'm open to either. ?(I'd be inclined toward renaming the > > action, since "bundle" isn't really a verb, and we should at least try > > to give our actions names that indicate what they do, not that we've > > been consistent about that in the past.) > > Hmm, I was thinking of bundle in it's verb form, like "bundle them > together". Do you have any suggestions for a good name? Perhaps > aggregate? I dunno, i suppose it doesn't bother me too much that the > names conflict because they are in completely different contexts (an > action vs a dpif concept). I'm fine with changing it though.
If you don't think it's confusing, then we can leave it for later in case it does. The "bundle" name inside ofproto/ is purely internal, not exposed outside OVS even through public headers, so it probably wouldn't be a big deal to change it later. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
