On Mon, Jul 18, 2011 at 09:39, Ben Pfaff <b...@nicira.com> wrote: > Doesn't check_output_port() reject OFPP_NONE at flow validation time? > (I remember talking to you about this, but not the conclusion.)
Yah it does, but the bundle_execute() function in a future patch returns OFPP_NONE if all the links are down. Ethan > > I don't see any harm in doing this, though. > > On Fri, Jul 15, 2011 at 01:50:00PM -0700, Ethan Jackson wrote: >> This provides a minor optimization. >> --- >> ofproto/ofproto-dpif.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c >> index 7264355..4d9d5da 100644 >> --- a/ofproto/ofproto-dpif.c >> +++ b/ofproto/ofproto-dpif.c >> @@ -2935,6 +2935,8 @@ xlate_output_action__(struct action_xlate_ctx *ctx, >> case OFPP_LOCAL: >> add_output_action(ctx, OFPP_LOCAL); >> break; >> + case OFPP_NONE: >> + break; >> default: >> if (port != ctx->flow.in_port) { >> add_output_action(ctx, port); >> -- >> 1.7.6 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> http://openvswitch.org/mailman/listinfo/dev > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev