On Tue, Jun 21, 2011 at 11:00:22AM -0700, Andrew Evans wrote:
> On Mon, 2011-06-20 at 13:25 -0700, Ben Pfaff wrote: 
> > -also has special support for Citrix XenServer hosts.
> > +also has special support for Citrix XenServer and Red Hat Enterprise
> > +Linux 5.6 hosts.
> 
> Will this also work on the forthcoming RHEL 5.7 release? Does this also
> include RHEL 6?

I deleted the version number here.

> > -    * Scripts and specs for building RPMs that allow Open vSwitch
> > +    * Scripts and specs for building RPMs for Citrix XenServer and Red
> > +      Hat Enterprise Linux 5.6.  The XenServer RPMs allow Open vSwitch
> 
> Same question here.

I deleted the version number here too.

> > +To build RPMs for installing Open vSwitch on a Red Hat Enterprise
> > +Linux 5.6 host, read INSTALL.RHEL-5.6.
> > +
> 
> Was this renamed to INSTALL.RHEL?

Yes, fixed, thanks.

> > +    help)
> > +        printf "$0 
> > [start|stop|restart|reload|force-reload|status|version]\n"
> 
> Should we mention force-reload-kmod here?

I added it, thanks.

> > diff --git a/rhel/kmodtool-openvswitch-el5.sh 
> > b/rhel/kmodtool-openvswitch-el5.sh
> 
> This looks ok to me, though I must admit I haven't studied it
> closely enough to really understand the interactions with the RPM
> spec file.

OK, thanks.

> > +# Magic hidden here.
> > +%{expand:%(sh %{SOURCE10} rpmtemplate_kmp %{kmod_name} %{kversion} 
> > %{kvariants})}
> 
> No kidding.

Oops, I forgot to add attributions for the spec files.  Here's what I
added to the RHEL5 version:

# Based on http://wiki.centos.org/HowTos/BuildingKernelModules by
# Akemi Yagi <[email protected]> and Alan Bartlett <[email protected]>.
# licensed under Creative Commons Attribution-Share Alike 3.0 Unported
# License.  Following copyright applies to changes:
#
# Copyright (C) 2009, 2010, 2011 Nicira Networks, Inc.

and the RHEL6 version:

# Based on example RPM spec from "Red Hat Driver Update Packages
# Official Reference Guide" by John Masters <[email protected]>, version
# 0.99, dated 2011-01-06.  Following copyright and license apply to
# changes:
#
# Copyright (C) 2011 Nicira Networks, Inc.
#
# Copying and distribution of this file, with or without modification,
# are permitted in any medium without royalty provided the copyright
# notice and this notice are preserved.  This file is offered as-is,
# without warranty of any kind.

The example didn't have a license attached to it, but it's clearly
intended for people to use and adapt.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to