On Mon, 2011-06-20 at 13:25 -0700, Ben Pfaff wrote: 
> -also has special support for Citrix XenServer hosts.
> +also has special support for Citrix XenServer and Red Hat Enterprise
> +Linux 5.6 hosts.

Will this also work on the forthcoming RHEL 5.7 release? Does this also
include RHEL 6?

> -    * Scripts and specs for building RPMs that allow Open vSwitch
> +    * Scripts and specs for building RPMs for Citrix XenServer and Red
> +      Hat Enterprise Linux 5.6.  The XenServer RPMs allow Open vSwitch

Same question here.

> +To build RPMs for installing Open vSwitch on a Red Hat Enterprise
> +Linux 5.6 host, read INSTALL.RHEL-5.6.
> +

Was this renamed to INSTALL.RHEL?

> +    help)
> +        printf "$0 [start|stop|restart|reload|force-reload|status|version]\n"

Should we mention force-reload-kmod here?

> diff --git a/rhel/kmodtool-openvswitch-el5.sh 
> b/rhel/kmodtool-openvswitch-el5.sh

This looks ok to me, though I must admit I haven't studied it closely enough to 
really understand the interactions with the RPM spec file.

> +# Magic hidden here.
> +%{expand:%(sh %{SOURCE10} rpmtemplate_kmp %{kmod_name} %{kversion} 
> %{kvariants})}

No kidding.

Thanks, this looks good to me otherwise.


_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to