Thanks, this looks good. I have only a few minor comments: On Thu, 2011-06-16 at 12:25 -0700, Ben Pfaff wrote: > diff --git a/INSTALL.RHEL-5.6 b/INSTALL.RHEL-5.6
Should we change the RHEL 5.6 references to RHEL 5? RHEL 5.7 is currently in beta, and there will probably be future RHEL 5 minor releases. I guess we might want to say that this might not work on RHEL 5.5 and earlier. > + rpmbuild \ > + -D "openvswitch_version <Open vSwitch version>" \ > + -D "kernel_version <kernel version>" \ > + -D "kernel_flavor <kernel flavor>" \ > + -bb openvswitch-$VERSION/rhel-5.6/openvswitch-rhel-5.6.spec Can we make this more similar to the rpmbuild command typically used to build Red Hat kmod packages? The required -D arguments seem unorthodox to me. There's an example kmod spec file and rpmbuild commands here: http://wiki.centos.org/HowTos/BuildingKernelModules > + set "$@" --force-oorefiles="$FORCE_COREFILES" Did you mean --force-corefiles? > + if test ! -e /var/run/openvswitch.booted; then > + touch /var/run/openvswitch.booted > + set "$@" --delete-bridges > + fi Is something else deleting /var/run/openvswitch.booted on system shutdown or OVS stop, or is this only supposed to run the first time OVS is started? > + force-reload-kmod) > + $ovs_ctl force_reload_kmod Doesn't ovs-ctl require force-reload-kmod? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
