On Thu, Jun 16, 2011 at 05:08:07PM -0700, Andrew Evans wrote:
> On Thu, 2011-06-16 at 14:12 -0700, Ben Pfaff wrote:
> > On Wed, Jun 15, 2011 at 06:55:38PM -0700, Andrew Evans wrote:
> > > When an error is encountered while parsing flows from a file, ovs-ofctl
> > > doesn't
> > > print the flow it can't parse, so it's not always obvious which flow is
> > > causing
> > > the error. Print the flow before the error message to make it clear.
> >
> > Could you write a helper function to do the job of this:
> >
> > if (verbose) {
> > fprintf(stderr, "%s:\n", str_);
> > }
> > ovs_fatal(0, "must specify an action");
>
> Ok, this looks a bit tidier:
Other than the issues that Reid pointed out, this looks OK to me.
Thanks.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
